[PATCH] D41052: [LLD] [MinGW] Don't pass -dynamicbase:no by default for arm/arm64

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: MinGW/Driver.cpp:162-165
+  if (Args.getLastArgValue(OPT_m) == "thumb2pe" ||
+      Args.getLastArgValue(OPT_m) == "arm64pe") {
+    if (Args.hasArg(OPT_dynamicbase))
+      Add("-dynamicbase");
----------------
My understanding is passing `-dynamicbase:no` on arm/arm64 doesn't make sense and should be considered error. Don't you want to remove this special condition and handle all targets equally (so that the error would be reported if you pass `-dynamicbase:no` on arm/arm64)?


https://reviews.llvm.org/D41052