[PATCH] D41060: Add an option for ICFing data

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

Got it. If you are using this option from the beginning, it should be fine.

It's not a big deal, but --icf-data sounds a bit odd, because ICF is short for Identical *Code* Folding. I have no better idea though.



================
Comment at: ELF/Options.td:146
 
+def icf_data: F<"icf-data">, HelpText<"Also fold identical data">;
+
----------------
Please rewrite the description so that it doesn't sound odd even if it's not displayed after --icf.


https://reviews.llvm.org/D41060