[PATCH] D41051: [LLD] [COFF] Disallow -dynamicbase:no for arm and arm64

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added a comment.

LGTM



================
Comment at: test/COFF/armnt-dynamicbase.test:3
+# RUN: not lld-link /out:%t.exe /entry:mainCRTStartup /subsystem:console %t.obj /dynamicbase:no 2>&1 | FileCheck %s
+# CHECK: dynamicbase:no is not compatible with arm
----------------
mstorsjo wrote:
> ruiu wrote:
> > You can merge this file and the assembly file because this file contains only comments.
> Which assembly file? This uses a different source file than the other test (which is for arm64); this uses a preexisting input file from the inputs subdirectory. But I could use a similar inline asm sub here as well instead of the inputs subdirectory yaml file, for consistency.
Ah, sorry I'm confused. Don't mind.


https://reviews.llvm.org/D41051