[PATCH] D40962: [ELF] When a relocation is out of range print the value and the range

[Rafael Avila de Espindola via llvm-commits]

Alexander Richardson via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:

> arichardson added inline comments.
>
>
> ================
> Comment at: ELF/Target.h:150
> +  error(getErrorLocation(Loc) + "relocation " + lld::toString(Type) +
> +        " out of range: requested value " + V + " is not in [" + Twine(Min) +
> +        ", " + Twine(Max) + "]");
> ----------------
> grimar wrote:
>> nit: I would shorten this:
>> relocation R_386_PC16 out of range: 65536 is not in [-65536, 65535]
>> It is the matter of taste though.
> Sounds good, I'll change if it to that if Rui also agrees.

LGTM with that wording suggestion, but wait for Rui's LGTM too.

Thanks,
Rafael