[PATCH] D40945: [ScalarEvolution] Improve high cost heuristic in SCEVExpander.

[Bevin Hansson via Phabricator via llvm-commits]

bevinh added inline comments.


================
Comment at: test/Analysis/ScalarEvolution/expensive-expansion.ll:39
+
+attributes #0 = { nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="false" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "unsafe-fp-math"="false" "use-soft-float"="false" }
----------------
sanjoy wrote:
> Is this necessary?
When I was constructing the reproducer, I couldn't get loop-unroll to unroll the loop if it wasn't present.

Looking closer now, it seems that removing the target triple and the target specific attributes is preventing the unroll from happening even if I undo the patch. I'll see if I can get it to work again.


https://reviews.llvm.org/D40945