[PATCH] D39950: [DebugInfo] Stable sort symbols to remove non-deterministic ordering

Eric Christopher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 7 16:50:26 PST 2017


echristo added a comment.

In https://reviews.llvm.org/D39950#948512, @probinson wrote:

> Well...  I'm not fully convinced that the stable_sort isn't just papering over some other problem, but it seems to be producing the correct final result.  If @echristo is okay with it, I'm okay with it.


I'm fairly convinced that's the case, that said, I'm more inclined to think we should rewrite this support and it seems somewhat mean to make mgrang do that as a new developer.


Repository:
  rL LLVM

https://reviews.llvm.org/D39950





More information about the llvm-commits mailing list