[PATCH] D40944: [profile] Enable on Solaris

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a reviewer: vsk.
vsk added inline comments.


================
Comment at: lib/profile/GCDAProfiling.c:39
 #define O_BINARY 0
 #endif
 #endif
----------------
Why not migrate O_BINARY to the common header as well?


================
Comment at: lib/profile/InstrProfilingUtil.c:116
+#else
+  flock(fd, LOCK_EX);
+  return 0;
----------------
Is flock available on Windows? If not, please handle that case by reporting a warning, and document the limitation near the header declarations of lprof(Un)lockFd.


================
Comment at: lib/profile/InstrProfilingUtil.c:134
+      if (errno == ENOLCK) {
+	return -1;
+      }
----------------
Please clang-format your changes.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D40944