[debuginfo-tests] r319790 - Temporarily pin tests to DWARF v2 until a more recent version of LLDB

Adrian Prantl via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 7 11:41:12 PST 2017


Reverted in r320076.

> On Dec 7, 2017, at 11:30 AM, Robinson, Paul <paul.robinson at sony.com> wrote:
> 
>> -----Original Message-----
>> From: Davide Italiano [mailto:davide.italiano at gmail.com]
>> Sent: Thursday, December 07, 2017 11:21 AM
>> To: Robinson, Paul
>> Cc: Adrian Prantl; llvm-commits at lists.llvm.org
>> Subject: Re: [debuginfo-tests] r319790 - Temporarily pin tests to DWARF v2
>> until a more recent version of LLDB
>> 
>> Yes, I think this can be reverted. What's the way to run these tests?
> 
> You need to have the debuginfo-tests project checked out (or soft-linked)
> under clang/test then `ninja check-clang` will find it automatically.  
> Also you need the native target configured, which for most people is X86.  
> On a mac the tests should use the host's lldb/dsymutil which ought to 
> catch any problems.
> --paulr
> 
>> 
>> Thanks,
>> 
>> --
>> Davide
>> 
>> On Thu, Dec 7, 2017 at 11:05 AM, Robinson, Paul via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>>> Hi Adrian,
>>> After r319995, this can probably be reverted?  I'd rather you do it,
>>> because you can verify on Mac before committing just to make sure.
>>> Thanks,
>>> --paulr
>>> 
>>>> -----Original Message-----
>>>> From: llvm-commits [mailto:llvm-commits-bounces at lists.llvm.org] On
>> Behalf
>>>> Of Adrian Prantl via llvm-commits
>>>> Sent: Tuesday, December 05, 2017 8:58 AM
>>>> To: llvm-commits at lists.llvm.org
>>>> Subject: [debuginfo-tests] r319790 - Temporarily pin tests to DWARF v2
>>>> until a more recent version of LLDB
>>>> 
>>>> Author: adrian
>>>> Date: Tue Dec  5 08:58:09 2017
>>>> New Revision: 319790
>>>> 
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=319790&view=rev
>>>> Log:
>>>> Temporarily pin tests to DWARF v2 until a more recent version of LLDB
>>>> is available on green dragon.
>>>> 
>>>> Modified:
>>>>    debuginfo-tests/trunk/asan-blocks.c
>>>>    debuginfo-tests/trunk/asan.c
>>>>    debuginfo-tests/trunk/nrvo-string.cpp
>>>>    debuginfo-tests/trunk/safestack.c
>>>>    debuginfo-tests/trunk/stack-var.c
>>>> 
>>>> Modified: debuginfo-tests/trunk/asan-blocks.c
>>>> URL: http://llvm.org/viewvc/llvm-project/debuginfo-tests/trunk/asan-
>>>> blocks.c?rev=319790&r1=319789&r2=319790&view=diff
>>>> 
>> ==========================================================================
>>>> ====
>>>> --- debuginfo-tests/trunk/asan-blocks.c (original)
>>>> +++ debuginfo-tests/trunk/asan-blocks.c Tue Dec  5 08:58:09 2017
>>>> @@ -1,4 +1,4 @@
>>>> -// RUN: %clang -fblocks %target_itanium_abi_host_triple -arch x86_64
>> %s -
>>>> o %t.out -g -fsanitize=address
>>>> +// RUN: %clang -fblocks %target_itanium_abi_host_triple -arch x86_64
>> %s -
>>>> o %t.out -gdwarf-2 -fsanitize=address
>>>> // RUN: %test_debuginfo %s %t.out
>>>> // FIXME: Remove system-darwin when we build BlocksRuntime everywhere.
>>>> // REQUIRES: not_asan, system-darwin
>>>> 
>>>> Modified: debuginfo-tests/trunk/asan.c
>>>> URL: http://llvm.org/viewvc/llvm-project/debuginfo-
>>>> tests/trunk/asan.c?rev=319790&r1=319789&r2=319790&view=diff
>>>> 
>> ==========================================================================
>>>> ====
>>>> --- debuginfo-tests/trunk/asan.c (original)
>>>> +++ debuginfo-tests/trunk/asan.c Tue Dec  5 08:58:09 2017
>>>> @@ -1,4 +1,4 @@
>>>> -// RUN: %clang -fblocks %target_itanium_abi_host_triple -arch x86_64
>> %s -
>>>> o %t.out -g -fsanitize=address
>>>> +// RUN: %clang -fblocks %target_itanium_abi_host_triple -arch x86_64
>> %s -
>>>> o %t.out -gdwarf-2 -fsanitize=address
>>>> // RUN: %test_debuginfo %s %t.out
>>>> // REQUIRES: not_asan
>>>> //           Zorg configures the ASAN stage2 bots to not build the
>> asan
>>>> 
>>>> Modified: debuginfo-tests/trunk/nrvo-string.cpp
>>>> URL: http://llvm.org/viewvc/llvm-project/debuginfo-tests/trunk/nrvo-
>>>> string.cpp?rev=319790&r1=319789&r2=319790&view=diff
>>>> 
>> ==========================================================================
>>>> ====
>>>> --- debuginfo-tests/trunk/nrvo-string.cpp (original)
>>>> +++ debuginfo-tests/trunk/nrvo-string.cpp Tue Dec  5 08:58:09 2017
>>>> @@ -1,9 +1,9 @@
>>>> // This ensures that DW_OP_deref is inserted when necessary, such as
>> when
>>>> NRVO
>>>> // of a string object occurs in C++.
>>>> //
>>>> -// RUN: %clangxx -O0 -fno-exceptions %target_itanium_abi_host_triple
>> %s -
>>>> o %t.out -g
>>>> +// RUN: %clangxx -O0 -fno-exceptions %target_itanium_abi_host_triple
>> %s -
>>>> o %t.out -gdwarf-2
>>>> // RUN: %test_debuginfo %s %t.out
>>>> -// RUN: %clangxx -O1 -fno-exceptions %target_itanium_abi_host_triple
>> %s -
>>>> o %t.out -g
>>>> +// RUN: %clangxx -O1 -fno-exceptions %target_itanium_abi_host_triple
>> %s -
>>>> o %t.out -gdwarf-2
>>>> // RUN: %test_debuginfo %s %t.out
>>>> //
>>>> // PR34513
>>>> 
>>>> Modified: debuginfo-tests/trunk/safestack.c
>>>> URL: http://llvm.org/viewvc/llvm-project/debuginfo-
>>>> tests/trunk/safestack.c?rev=319790&r1=319789&r2=319790&view=diff
>>>> 
>> ==========================================================================
>>>> ====
>>>> --- debuginfo-tests/trunk/safestack.c (original)
>>>> +++ debuginfo-tests/trunk/safestack.c Tue Dec  5 08:58:09 2017
>>>> @@ -1,4 +1,4 @@
>>>> -// RUN: %clang %target_itanium_abi_host_triple -arch x86_64 %s -o
>> %t.out
>>>> -g -fsanitize=safe-stack
>>>> +// RUN: %clang %target_itanium_abi_host_triple -arch x86_64 %s -o
>> %t.out
>>>> -gdwarf-2 -fsanitize=safe-stack
>>>> // RUN: %test_debuginfo %s %t.out
>>>> // REQUIRES: not_asan
>>>> //           Zorg configures the ASAN stage2 bots to not build the
>>>> 
>>>> Modified: debuginfo-tests/trunk/stack-var.c
>>>> URL: http://llvm.org/viewvc/llvm-project/debuginfo-tests/trunk/stack-
>>>> var.c?rev=319790&r1=319789&r2=319790&view=diff
>>>> 
>> ==========================================================================
>>>> ====
>>>> --- debuginfo-tests/trunk/stack-var.c (original)
>>>> +++ debuginfo-tests/trunk/stack-var.c Tue Dec  5 08:58:09 2017
>>>> @@ -1,4 +1,4 @@
>>>> -// RUN: %clang %target_itanium_abi_host_triple %s -O -o %t.out -g
>>>> +// RUN: %clang %target_itanium_abi_host_triple %s -O -o %t.out -
>> gdwarf-2
>>>> // RUN: %test_debuginfo %s %t.out
>>>> 
>>>> void __attribute__((noinline, optnone)) bar(int *test) {}
>>>> 
>>>> 
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at lists.llvm.org
>>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>> 
>> 
>> 
>> --
>> Davide
>> 
>> "A mathematical theory is not to be considered complete until you have
>> made it so clear that you can explain it to the first man whom you
>> meet on the street." (D. Hilbert)



More information about the llvm-commits mailing list