[llvm] r319997 - [DebugInfo] Explicitly pass a triple to this test.

[Davide Italiano via llvm-commits]

I think I understand what's going on. It's lit doing a substitution, i.e.

    ToolSubst('%llc_dwarf', FindTool('llc'), extra_args=llc_args),


llc_args = []

# Similarly, have a macro to use llc with DWARF even when the host is win32.
if re.search(r'win32', config.target_triple):
    llc_args = [' -mtriple=' +
                config.target_triple.replace('-win32', '-mingw32')]


Galina, can you please try the following patch? If that works, I'll commit.

$ git diff
diff --git a/test/DebugInfo/X86/nodebug.ll b/test/DebugInfo/X86/nodebug.ll
index 67dd6549a4c..a5ad5e08c41 100644
--- a/test/DebugInfo/X86/nodebug.ll
+++ b/test/DebugInfo/X86/nodebug.ll
@@ -1,6 +1,6 @@
 ; REQUIRES: object-emission

-; RUN: %llc_dwarf < %s -filetype=obj -mtriple=x86_64-apple-darwin |
llvm-dwarfdump -v - | FileCheck %s
+; RUN: llc < %s -filetype=obj -mtriple=x86_64-apple-darwin |
llvm-dwarfdump -v - | FileCheck %s

 ; Test that a nodebug function (a function not appearing in the debug info IR
 ; metadata subprogram list) with DebugLocs on its IR doesn't cause crashes/does

On Thu, Dec 7, 2017 at 11:19 AM, Davide Italiano <davide at freebsd.org> wrote:
> This is not related to my commit, something (presumably the driver?)
> is passing a mingw triple?
> I don't even know how to debug this because I don't have access to a
> machine with that triple.
> CC:ing Martin/Martell as they might now what's going on.
>
> ******************** TEST 'LLVM :: DebugInfo/Generic/nodebug.ll'
> FAILED ********************
> Script:
> --
> C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\build\bin\llc.EXE
>  -mtriple=x86_64-pc-mingw32 <
> C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\llvm\test\DebugInfo\Generic\nodebug.ll
> -filetype=obj -mtriple=x86_64-apple-darwin |
> C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\build\bin\llvm-dwarfdump.EXE
> -v - | C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\build\bin\FileCheck.EXE
> C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\llvm\test\DebugInfo\Generic\nodebug.ll
> --
> Exit Code: 2
>
> Command Output (stdout):
> --
> $ "C:\ps4-buildslave2\llvm-clang-x86_64-expensive-checks-win\build\bin\llc.EXE"
> "-mtriple=x86_64-pc-mingw32" "-filetype=obj"
> "-mtriple=x86_64-apple-darwin"
> # command stderr:
> llc.EXE: for the -mtriple option: may only occur zero or one times!
>
> On Thu, Dec 7, 2017 at 11:09 AM, Galina Kistanova <gkistanova at gmail.com> wrote:
>> Hello Davide,
>>
>> One of your resent commits broke the test on the builder:
>>
>> http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/6619
>>
>> . . .
>> Failing Tests (2):
>> . . .
>>     LLVM :: DebugInfo/Generic/nodebug.ll
>> . . .
>>
>> Please have a look?
>> The builder was already red and did not send notifications.
>>
>> Thanks
>>
>> Galina
>>
>> On Wed, Dec 6, 2017 at 5:22 PM, Davide Italiano via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>>>
>>> Author: davide
>>> Date: Wed Dec  6 17:22:10 2017
>>> New Revision: 319997
>>>
>>> URL: http://llvm.org/viewvc/llvm-project?rev=319997&view=rev
>>> Log:
>>> [DebugInfo] Explicitly pass a triple to this test.
>>>
>>> As we emit different linetables format on different operating
>>> systems, this currently fails on linux. Speculative commit
>>> to fix the bots.
>>>
>>> Modified:
>>>     llvm/trunk/test/DebugInfo/Generic/nodebug.ll
>>>
>>> Modified: llvm/trunk/test/DebugInfo/Generic/nodebug.ll
>>> URL:
>>> http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/Generic/nodebug.ll?rev=319997&r1=319996&r2=319997&view=diff
>>>
>>> ==============================================================================
>>> --- llvm/trunk/test/DebugInfo/Generic/nodebug.ll (original)
>>> +++ llvm/trunk/test/DebugInfo/Generic/nodebug.ll Wed Dec  6 17:22:10 2017
>>> @@ -1,6 +1,6 @@
>>>  ; REQUIRES: object-emission
>>>
>>> -; RUN: %llc_dwarf < %s -filetype=obj | llvm-dwarfdump -v - | FileCheck %s
>>> +; RUN: %llc_dwarf < %s -filetype=obj -mtriple=x86_64-apple-darwin |
>>> llvm-dwarfdump -v - | FileCheck %s
>>>
>>>  ; Test that a nodebug function (a function not appearing in the debug
>>> info IR
>>>  ; metadata subprogram list) with DebugLocs on its IR doesn't cause
>>> crashes/does
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>
>>
>
>
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare



-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare