[llvm] r319997 - [DebugInfo] Explicitly pass a triple to this test.

[Yvan Roux via llvm-commits]

On 7 December 2017 at 17:11, Davide Italiano <davide at freebsd.org> wrote:
> r320057. Cheers.

Thanks for the fix.

> On Thu, Dec 7, 2017 at 7:51 AM, Davide Italiano <davide at freebsd.org> wrote:
>> On Thu, Dec 7, 2017 at 2:00 AM, Yvan Roux <yvan.roux at linaro.org> wrote:
>>> Hi Davide,
>>>
>>> On 7 December 2017 at 02:22, Davide Italiano via llvm-commits
>>> <llvm-commits at lists.llvm.org> wrote:
>>>> Author: davide
>>>> Date: Wed Dec  6 17:22:10 2017
>>>> New Revision: 319997
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=319997&view=rev
>>>> Log:
>>>> [DebugInfo] Explicitly pass a triple to this test.
>>>>
>>>> As we emit different linetables format on different operating
>>>> systems, this currently fails on linux. Speculative commit
>>>> to fix the bots.
>>>>
>>>> Modified:
>>>>     llvm/trunk/test/DebugInfo/Generic/nodebug.ll
>>>>
>>>> Modified: llvm/trunk/test/DebugInfo/Generic/nodebug.ll
>>>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/DebugInfo/Generic/nodebug.ll?rev=319997&r1=319996&r2=319997&view=diff
>>>> ==============================================================================
>>>> --- llvm/trunk/test/DebugInfo/Generic/nodebug.ll (original)
>>>> +++ llvm/trunk/test/DebugInfo/Generic/nodebug.ll Wed Dec  6 17:22:10 2017
>>>> @@ -1,6 +1,6 @@
>>>>  ; REQUIRES: object-emission
>>>>
>>>> -; RUN: %llc_dwarf < %s -filetype=obj | llvm-dwarfdump -v - | FileCheck %s
>>>> +; RUN: %llc_dwarf < %s -filetype=obj -mtriple=x86_64-apple-darwin | llvm-dwarfdump -v - | FileCheck %s
>>>
>>> This ARM and AArch64 bots are still broken with this as they don't
>>> have x86_64-apple-darwin backend support.  I still don't know well the
>>> testsuite syntax (I'm new in the community) but I d'on't think
>>> restricting this test to x86_64 darwin target is the right fix for the
>>> previous regression, since it will is will remove a test which did
>>> work on other targets, it should be better to check the expected value
>>> on each targets.
>>>
>>
>> I can still probably add something like `REQUIRES: x86`.
>> I'll try it now. BTW, do you have a link to the bots so I can monitor
>> them by any chance?
>> Sorry for the breakage.

The bots are clang-cmake-[armv7|thumbv7|aarch64]* ones on this page:

http://lab.llvm.org:8011/builders/

Thanks.
Yvan



>> --
>> Davide
>
>
>
> --
> Davide
>
> "There are no solved problems; there are only problems that are more
> or less solved" -- Henri Poincare