[PATCH] D40836: [CodeGen] Use MachineOperand::print in the MIRPrinter for MO_Register.

[Francis Visoiu Mistrih via Phabricator via llvm-commits]

thegameg closed this revision.
thegameg marked 9 inline comments as done.
thegameg added a comment.

Committed as r320022 <https://reviews.llvm.org/rL320022> [CodeGen] Use MachineOperand::print in the MIRPrinter for MO_Register.



================
Comment at: lib/CodeGen/LiveVariables.cpp:238
     // AH =
-    // AL = ... <imp-def EAX>, <imp-kill AH>
     //    = AH
----------------
MatzeB wrote:
> thegameg wrote:
> > I also assumed `<imp-kill>` here meant `implicit-use killed`.
> yes it's an implicit use with a kill flag. Is there anything confusing here?
> 
> I know the syntax used in the comments isn't always consistent. We also have this strange thing in .mir where `implicit-def` is just another word for `implicit def` (but that is something to fix another day).
Right, I was wondering why not <imp-use,kill>.


https://reviews.llvm.org/D40836