[PATCH] D38406: [dump] Make LLVM_ENABLE_DUMP independent, and move to llvm-config.h

Justin Bogner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 6 22:23:21 PST 2017


bogner added inline comments.


================
Comment at: include/llvm/Config/llvm-config.h.cmake:17
 
+/* Define if LLVM_ENABLE_DUMP is enabled */
+#cmakedefine LLVM_ENABLE_DUMP
----------------
Maybe this should say "provide dump methods, even in release builds". Most of the flags in this file are written in the "what does it do" style rather than the "how does it do it" style.


https://reviews.llvm.org/D38406





More information about the llvm-commits mailing list