[PATCH] D40928: Remove checkToString functions and use toString instead.

[Rafael Avila de Espindola via llvm-commits]

Rui Ueyama <ruiu at google.com> writes:

> On Wed, Dec 6, 2017 at 5:30 PM, Rafael Avila de Espindola <
> rafael.espindola at gmail.com> wrote:
>
>> LGTM
>>
>> BTW, as a followup you can even convert the macro to a template
>> function, no?
>
>
> For something like CHECK(foo, this), yes, but in general, no. For example,
> we cannot lazy-evaluate the second argument in CHECK(foo, toString(this) +
> ": out of range")) using template.

I see.

In any case, this patch is an improvement as is. LGTM.

Thanks,
Rafael