[PATCH] D40932: Hardware-assisted AddressSanitizer (llvm part).

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added a comment.

Please document the new attribute and explain why the old attribute doesn't work for us (there are cases when we need one, but not the other, in both directions)



================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:15
+
+#include "llvm/ADT/APInt.h"
+#include "llvm/ADT/ArrayRef.h"
----------------
Do you really need all these includes? 


================
Comment at: llvm/lib/Transforms/Instrumentation/HWAddressSanitizer.cpp:102
+
+/// \brief An instrumentation pass implementing detection of uninitialized
+/// reads.
----------------
update comment


https://reviews.llvm.org/D40932