[PATCH] D40728: [CallSiteSplitting] Refactor creating callsites.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 6 14:53:45 PST 2017


fhahn added inline comments.


================
Comment at: test/Transforms/CallSiteSplitting/callsite-split-or-phi.ll:354
+;CHECK: ret i32 %[[MERGED]]
+define i32 @test_eq_eq_eq_untaken(i32* %a, i32 %v, i32 %p) {
+Header:
----------------
junbuml wrote:
> In order to prevent any future change from breaking this pass, I believe we need more test cases including eq_eq_eq_taken. It will be also good to add a test case where the same argument is used multiple ICMPs. 
Agreed, I'll add such a test cases tomorrow.


https://reviews.llvm.org/D40728





More information about the llvm-commits mailing list