[PATCH] D40863: [AArch64][Darwin] Implement stack probing for static and dynamic stack objects

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 6 13:31:47 PST 2017


efriedma added inline comments.


================
Comment at: lib/Target/AArch64/AArch64FrameLowering.cpp:560
     else {
+      if (NumBytes > StackProbeSize && ProbeSym != "")
+        emitStackProbe(MF, MBB, MBBI, DL, NumBytes);
----------------
Needs a comment to explain why NumBytes < StackProbeSize doesn't need a stack probe.  (On x86, the "CALL" instruction stores the return pointer onto the stack, which simplifies the logic, but there isn't any equivalent on AArch64.)


Repository:
  rL LLVM

https://reviews.llvm.org/D40863





More information about the llvm-commits mailing list