[lld] r319922 - Add a checkLazy error checking variant.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 6 12:53:51 PST 2017


I sent you https://reviews.llvm.org/D40915 to do that.

On Wed, Dec 6, 2017 at 12:52 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Rui Ueyama <ruiu at google.com> writes:
>
> > I want to keep the number of functions in ErrorHandler as small as
> possible
> > for the sake of simplicity. As you added a new function, now we have to
> > think which we should use when we write code, check or checkLazy.
> >
> > Have you considered making every call of `check` lazy? I'm OK with using
> C
> > macro if not too complicated.
>
> Making it always lazy might make sense.
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171206/e8e2774f/attachment.html>


More information about the llvm-commits mailing list