[PATCH] D35625: Removal of microMIPS64R6

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 6 07:34:38 PST 2017


sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.

LTGM with the inlined nits addressed, along with any other changes that have to be made during rebasing before commit provided they're obvious/minor.



================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:7122
+    if (hasMips64r6()) {
+      Error(Tok.getLoc(), "micromips directive is not supported with mips64r6 cpu");
+      return false;
----------------
".set micromips directive is not supported with MIPS64R6"


================
Comment at: lib/Target/Mips/AsmParser/MipsAsmParser.cpp:7158
+    if (inMicroMipsMode()) {
+      Error(Tok.getLoc(), "mips64r6 does not support microMIPS mode");
+      return false;
----------------
"MIPS64R6 is not supported with microMIPS"


Repository:
  rL LLVM

https://reviews.llvm.org/D35625





More information about the llvm-commits mailing list