[PATCH] D40229: [cmake] Remove redundant call to cmake when building host tools.

Pavel Labath via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 6 06:00:14 PST 2017


On 6 December 2017 at 13:40, Don Hinton <hintonda at gmail.com> wrote:
> Would handling them like the linker flags and only passing them when not
> cross compiling fix this?

Yes, I believe it will (Is this code ever invoked when *not* cross-compiling?).

However, I still think the CROSS_TOOLCHAIN_FLAGS should come last, as
this gives the user the opportunity to override any of our arguments
for any reason he sees fit. E.g., I can see how someone might want to
use CMAKE_BUILD_TYPE=Release for the host tblgen targets, but still
build the main thing in debug mode.

Is there any reason that can't be done?


More information about the llvm-commits mailing list