[PATCH] D40879: [X86][I86][I186][I386][I486]: Adding full coverage of MC encoding for the I86, I186, I386 and I486 isa sets.<NFC>

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 23:36:13 PST 2017


craig.topper added a comment.

Is breaking these up by generations that old even meaningful? Its pretty difficult these days to know when different instructions were added that pre-dated cpuid feature flags. Should we just have 2 files for this the -32 and -64?

Why are instructions like addw, xorw, etc. missing?

Why are there substantially more tests for xorb than xorl? Similar for addb vs addl?


Repository:
  rL LLVM

https://reviews.llvm.org/D40879





More information about the llvm-commits mailing list