[PATCH] D40766: Handle NetBSD symbol renaming in msan_interceptors.cc

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: lib/msan/msan_interceptors.cc:47
+#if SANITIZER_NETBSD
+#define sigaction_symname __sigaction14
+#else
----------------
krytarowski wrote:
> vitalybuka wrote:
> > Why not the same for __libc_thr_keycreate?
> This one we are not intercepting here, but calling with REAL(). We need to use a 3rd party symbol name in order to not mangle too much, as there are struct fields named 'sigaction'.
could you please use all capitals in macro names for consistency?

maybe better place for this macros is
sanitizer_platform_limits_netbsd.h and sanitizer_platform_limits_posix.h


Repository:
  rL LLVM

https://reviews.llvm.org/D40766