[PATCH] D39798: [Sanitizers] Use SANITIZER_* macros in lib/interception

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 16:13:29 PST 2017


vitalybuka accepted this revision.
vitalybuka added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/interception/interception_mac.cc:17
 
+#if SANITIZER_MAC
 
----------------
ro wrote:
> krytarowski wrote:
> > ro wrote:
> > > ro wrote:
> > > > krytarowski wrote:
> > > > > Does it make sense?
> > > > How do you mean?  One could do away with the effectively empty
> > > > file completely.
> > > Sorry but I still don't know what you mean here.
> > I would just drop this:
> > 
> > ```
> > #if SANITIZER_MAC
> > #endif
> > ```
> Fine with me.  However, there's the risk of breaking non-OS X
> builds if there's code added to the file and the guard forgotten...
> 
> But let's cross that bridge when/if we get there.
I'd probably keep this for consistency with other platform specific files.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D39798





More information about the llvm-commits mailing list