[PATCH] D38406: [dump] Remove NDEBUG from test to enable dump methods [NFC]

Don Hinton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 15:45:03 PST 2017


hintonda added a comment.

In https://reviews.llvm.org/D38406#945890, @bogner wrote:

> I'm also confused about how this works before this change, if multi-config generators only create one set of headers. Currently, we're already defining LLVM_ENABLE_DUMP in config.h, so how does MSVC handle the fact that this already has different values for different configs?


That's the problem, as far as I can tell, it never worked.  It always depended on NDEBUG.


https://reviews.llvm.org/D38406





More information about the llvm-commits mailing list