[PATCH] D38406: [dump] Remove NDEBUG from test to enable dump methods [NFC]

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 15:36:27 PST 2017


MatzeB added a comment.

In https://reviews.llvm.org/D38406#945869, @bogner wrote:

> In https://reviews.llvm.org/D38406#945845, @hintonda wrote:
>
> > My solution would support buildbots, developer builds, and installed versions via llvm-config.
>
>
> I don't understand how this version supports installed versions, the define doesn't appear in llvm-config at all here. Can you explain?


While I could see an `llvm-config` solution working, I'd really rather see us try the llvm-config.h solution first. In my experience people who do not come from a unix/linux background usually setup their own projects in various IDEs and do not profit from an llvm-config tool feeding them the right flags, they would have to discover the right flags themselfes if they aren't in llvm-config.h.


https://reviews.llvm.org/D38406





More information about the llvm-commits mailing list