[PATCH] D40861: [X86] Add support for stack probing on x86_64 Darwin

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 15:13:56 PST 2017


aemerson added a comment.

In https://reviews.llvm.org/D40861#945805, @majnemer wrote:

> I'm a little confused here, is the intent that this will be the default on the platform? If not, can you explain the functional difference between this and just using the "probe-stack" attribute with ___chkstk_darwin?


Yes, that's the intention. There are also ABI differences between Darwin and Windows meaning that we need to potentially save RAX entry. This patch is trying to generalise the existing support hence why I've renamed things to make it less Windows-specific (although of course it's still not universally supported, just extended to Darwin).


Repository:
  rL LLVM

https://reviews.llvm.org/D40861





More information about the llvm-commits mailing list