[PATCH] D40842: [ObjectYAML] Update obj2yaml and yaml2obj for .debug$H section

David Majnemer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 14:52:33 PST 2017


majnemer added inline comments.


================
Comment at: llvm/lib/ObjectYAML/CodeViewYAMLTypeHashing.cpp:51-54
+  BinaryStreamReader Reader(DebugT, llvm::support::little);
+  DebugHSection DHS;
+  cantFail(Reader.readInteger(DHS.Version));
+  cantFail(Reader.readInteger(DHS.HashAlgorithm));
----------------
Seeing as how nothing stops MSFT from using the debug$H section for something of their own invention, maybe we should have a magic four byte sequence at the section start to identify that we made it?


https://reviews.llvm.org/D40842





More information about the llvm-commits mailing list