[PATCH] D39147: [AArch64] Do not abort if overflow check does not use EQ or NE.

Joel Galenson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 13:33:51 PST 2017


This revision was automatically updated to reflect the committed changes.
Closed by commit rL319837: [AArch64] Do not abort if overflow check does not use EQ or NE. (authored by jgalenson).

Changed prior to commit:
  https://reviews.llvm.org/D39147?vs=119719&id=125600#toc

Repository:
  rL LLVM

https://reviews.llvm.org/D39147

Files:
  llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp


Index: llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp
===================================================================
--- llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp
+++ llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp
@@ -4006,9 +4006,8 @@
 
   // Optimize {s|u}{add|sub|mul}.with.overflow feeding into a branch
   // instruction.
-  if (isOverflowIntrOpRes(LHS) && isOneConstant(RHS)) {
-    assert((CC == ISD::SETEQ || CC == ISD::SETNE) &&
-           "Unexpected condition code.");
+  if (isOverflowIntrOpRes(LHS) && isOneConstant(RHS) &&
+      (CC == ISD::SETEQ || CC == ISD::SETNE)) {
     // Only lower legal XALUO ops.
     if (!DAG.getTargetLoweringInfo().isTypeLegal(LHS->getValueType(0)))
       return SDValue();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39147.125600.patch
Type: text/x-patch
Size: 752 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171205/8c6459ef/attachment.bin>


More information about the llvm-commits mailing list