[PATCH] D40512: [Debugify] Add a pass to test debug info preservation

[Davide Italiano via Phabricator via llvm-commits]

davide accepted this revision.
davide added a comment.
This revision is now accepted and ready to land.

This looks good to me modulo minor, happy to see this in if Matthias/Adrian are happy with it.



================
Comment at: tools/opt/Debugify.cpp:54
+    }
+    return DTy;
+  };
----------------
should this be `return true`? 


================
Comment at: tools/opt/Debugify.cpp:143-144
+
+      errs() << "ERROR: Instruction with empty DebugLoc -- ";
+      I.print(errs());
+      errs() << "\n";
----------------
I wonder whether this should be under `DEBUG()`, so that we don't clutter the release builds?


https://reviews.llvm.org/D40512