[PATCH] D40033: [NVPTX] Initial adaptation of MCAsmStreamer/MCTargetStreamer for debug info in Cuda.

[Alexey Bataev via Phabricator via llvm-commits]

ABataev added inline comments.


================
Comment at: lib/MC/MCAsmStreamer.cpp:1101
+  } else {
+    EmitRawText(OS1.str());
   }
----------------
tra wrote:
> We do not print EOL after the file name any more. Is that intentional?
`EmitRawText` emits EOL automatically.


================
Comment at: lib/MC/MCStreamer.cpp:62-64
+void MCTargetStreamer::emitDwarfFileDirective(StringRef Directive) {
+  Streamer.EmitRawText(Directive);
+}
----------------
tra wrote:
> Do you have further plans to do something more elaborate here? Otherwise I'd remove it and just use EmitRawText.
Sure, I have plans. As soon as this patch is accepted, I'm going to publish next patches with debug info support for NVPTX. This is just the first part.


https://reviews.llvm.org/D40033