[PATCH] D40845: Wasm COMDAT: LLD support

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 10:34:13 PST 2017


ncw created this revision.
Herald added subscribers: llvm-commits, sunfish, aheejin, jfb.

WORK IN PROGRESS - but it does function and works on the testcases I've tried so far

See https://bugs.llvm.org/show_bug.cgi?id=35533, and https://reviews.llvm.org/D40844

Things covered:

- "Compressing" the table of function pointers to ensure all pointers to same function have the same value
- Removing duplicate data segments (as determined by COMDATs emitted by the frontend)
- Removing duplicate globals and functions in COMDATs
- Checking that each time a COMDAT is seen it has the same symbols as at other times (ie it's a stronger check than simply giving all the symbols in the COMDAT weak linkage)


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D40845

Files:
  wasm/InputFiles.cpp
  wasm/InputFiles.h
  wasm/InputSegment.cpp
  wasm/InputSegment.h
  wasm/OutputSegment.h
  wasm/SymbolTable.cpp
  wasm/SymbolTable.h
  wasm/Symbols.cpp
  wasm/Symbols.h
  wasm/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40845.125571.patch
Type: text/x-patch
Size: 19825 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171205/aeb10498/attachment.bin>


More information about the llvm-commits mailing list