[PATCH] D40725: Wasm entrypoint changes #3 (add --no-entry argument to LLD) APPLY AFTER D40559

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 09:26:57 PST 2017


ncw updated this revision to Diff 125553.
ncw marked 3 inline comments as done.
ncw added a comment.

Feedback addressed.

- Added check to disallow using empty string with `--entry` and `--undefined`
- Got rid of use of null StringRef for Entry
- Switched Entry to an Optional so code expresses intent more clearly by checking `if (Config->Entry)` rather than `if (Config->Entry.empty())`


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D40725

Files:
  test/wasm/data-layout.ll
  wasm/Config.h
  wasm/Driver.cpp
  wasm/Options.td
  wasm/Writer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40725.125553.patch
Type: text/x-patch
Size: 5837 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171205/af3c89a6/attachment.bin>


More information about the llvm-commits mailing list