[PATCH] D40777: [dsymutil] Add -verify option to run DWARF verifier after linking.

[Jonas Devlieghere via Phabricator via llvm-commits]

JDevlieghere marked 2 inline comments as done.
JDevlieghere added inline comments.


================
Comment at: test/tools/dsymutil/X86/verify.test:4
+RUN: cat %p/../Inputs/basic-lto.macho.x86_64 > %T/basic-lto.macho.x86_64
+RUN: cat %p/../Inputs/basic-lto-dw4.macho.x86_64 > %T/basic-lto-dw4.macho.x86_64
+
----------------
vsk wrote:
> Why are the copies needed?
Thanks! I had copied this from another test where the flat mode mattered and output was written to the temp folder. It's not necessary for this test so we don't need the copies. 


================
Comment at: tools/dsymutil/dsymutil.cpp:105
+         "default."),
+    value_desc("arch"), ZeroOrMore, cat(DsymCategory));
 
----------------
probinson wrote:
> This looks like an unrelated formatting change?
> Also later on a couple of extra blank lines were removed.  I'm guessing you ran clang-format on the whole file instead of using clang-format-diff.  Generally we prefer whitespace/formatting changes to be done separately from functional changes.
Jup, this was unintentional. In addition to git clang-format before uploading the patch, I usually format new code in my editor by visually selecting it. However if you're in normal mode, it formats the whole file which is what must have happened here. 


Repository:
  rL LLVM

https://reviews.llvm.org/D40777