[PATCH] D40790: DAGCombiner bugfix in MergeStoresOfConstantsOrVecElts()

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 5 06:17:16 PST 2017


spatel added a comment.

In https://reviews.llvm.org/D40790#944803, @jonpa wrote:

> > Did this bug start after r319036?
>
> This problem disappeared at least on the test case when I reverted that patch, so yes, this seems to be the cause (It also explains why I all of a sudden got some 10 csmith wrong-code results relating to this recently...)


Sorry I hadn't seen it until now, but https://reviews.llvm.org/D40701 is a superset of this fix. I think we can abandon this (though we might want to include a SystemZ test for extra coverage).


https://reviews.llvm.org/D40790





More information about the llvm-commits mailing list