[PATCH] D38406: [dump] Remove NDEBUG from test to enable dump methods [NFC]

[Don Hinton via Phabricator via llvm-commits]

hintonda reopened this revision.
hintonda added a comment.
This revision is now accepted and ready to land.

Re-opening:

This was reverted in https://reviews.llvm.org/rL315854 due to bot failures using multi-configuration generators, e.g., XCode and MSVC.

There were 2 issues:

1. LLVM_ENABLE_DEBUG was missing on some dump declartions,
2. LLVM_ENABLE_DEBUG was set based on CMAKE_BUILD_TYPE which isn't set when using multi-configuration generators.

We can fix 1 as needed, and 2 by adding LLVM_ENABLE_DUMP to CMAKE_CXX_FLAGS_(RELEASE|MINSIZEREL) as needed.


Repository:
  rL LLVM

https://reviews.llvm.org/D38406