[llvm] r319708 - [msan] Add a fixme note for a minor deficiency.

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 4 14:50:39 PST 2017


Author: eugenis
Date: Mon Dec  4 14:50:39 2017
New Revision: 319708

URL: http://llvm.org/viewvc/llvm-project?rev=319708&view=rev
Log:
[msan] Add a fixme note for a minor deficiency.

Modified:
    llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp

Modified: llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp?rev=319708&r1=319707&r2=319708&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp (original)
+++ llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp Mon Dec  4 14:50:39 2017
@@ -2772,6 +2772,8 @@ struct MemorySanitizerVisitor : public I
         setOrigin(&I, getCleanOrigin());
         return;
       }
+      // FIXME: NextInsn is likely in a basic block that has not been visited yet.
+      // Anything inserted there will be instrumented by MSan later!
       NextInsn = NormalDest->getFirstInsertionPt();
       assert(NextInsn != NormalDest->end() &&
              "Could not find insertion point for retval shadow load");




More information about the llvm-commits mailing list