[PATCH] D40699: Split IndirectBr critical edges before PGO gen/use passes.

Hiroshi Yamauchi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 4 10:44:50 PST 2017


yamauchi added inline comments.


================
Comment at: lib/Passes/PassBuilder.cpp:515
+    // that's done during the pass.
+    MPM.addPass(SplitIndirectBrCriticalEdgesPass());
     MPM.addPass(PGOInstrumentationGen());
----------------
davidxl wrote:
> this is common to Use and Gen, so it is possible to move it into the previous SCC pipeline after InstCombinePass.
Do you mean moving this to after line 498 above? If so, would it not work if isOptimizingForSize() is true?


https://reviews.llvm.org/D40699





More information about the llvm-commits mailing list