[PATCH] D40735: [LLD][ELF] InX::BssRelRo should check section contents before marking relro

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 4 08:43:19 PST 2017


peter.smith added a comment.

I agree with your summary, and I'll remove the .space pre-commit. Will wait till tomorrow to do so.



================
Comment at: test/ELF/relro-copyrel-bss-script.s:24-25
+
+        .data
+        .space 4
+
----------------
jhenderson wrote:
> Does this bit do anything in the test? If not, please delete it. If it does, please comment on its purpose.
I'll remove it. It is a hold over from a previous test where I wanted some non bss, non relro data after the relro for .dynamic etc, but that won't happen with this linker script.
 


https://reviews.llvm.org/D40735





More information about the llvm-commits mailing list