[PATCH] D40769: [ARM] Allow using emulated tls on platforms other than ELF

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo created this revision.
Herald added subscribers: kristof.beyls, javed.absar, aemerson.

This matches how it is done on X86.

This allows using emulated tls on windows; in MinGW environments, native tls isn't supported at the moment.


https://reviews.llvm.org/D40769

Files:
  lib/Target/ARM/ARMISelLowering.cpp
  test/CodeGen/ARM/emutls_generic.ll


Index: test/CodeGen/ARM/emutls_generic.ll
===================================================================
--- test/CodeGen/ARM/emutls_generic.ll
+++ test/CodeGen/ARM/emutls_generic.ll
@@ -6,6 +6,8 @@
 ; RUN:     | FileCheck -check-prefix=ARM_32 %s
 ; RUN: llc < %s -emulated-tls -mtriple=arm-linux-androidabi -O3 \
 ; RUN:     | FileCheck -check-prefix=ARM_32 %s
+; RUN: llc < %s -emulated-tls -mtriple=thumbv7-windows-gnu -O3 \
+; RUN:     | FileCheck -check-prefix=WIN %s
 
 ; Make sure that TLS symbols are emitted in expected order.
 
@@ -61,3 +63,40 @@
 ; ARM_32-LABEL:  __emutls_t.internal_y:
 ; ARM_32-NEXT:   .long 9
 ; ARM_32-NEXT:   .long 0
+
+; WIN-LABEL:  get_external_x:
+; WIN:        movw r0, :lower16:__emutls_v.external_x
+; WIN:        movt r0, :upper16:__emutls_v.external_x
+; WIN:        bl __emutls_get_address
+; WIN-LABEL:  get_external_y:
+; WIN:        movw r0, :lower16:__emutls_v.external_y
+; WIN:        movt r0, :upper16:__emutls_v.external_y
+; WIN:        bl __emutls_get_address
+; WIN-LABEL:  get_internal_y:
+; WIN:        movw r0, :lower16:__emutls_v.internal_y
+; WIN:        movt r0, :upper16:__emutls_v.internal_y
+; WIN:        bl __emutls_get_address
+; WIN-NOT:    __emutls_t.external_x
+; WIN-NOT:    __emutls_v.external_x:
+; WIN:        .data{{$}}
+; WIN:        .globl __emutls_v.external_y
+; WIN:        .p2align 2
+; WIN-LABEL:  __emutls_v.external_y:
+; WIN-NEXT:   .long 1
+; WIN-NEXT:   .long 2
+; WIN-NEXT:   .long 0
+; WIN-NEXT:   .long __emutls_t.external_y
+; WIN:        .section .rdata,
+; WIN-LABEL:  __emutls_t.external_y:
+; WIN-NEXT:   .byte 7
+; WIN:        .data{{$}}
+; WIN-NOT:    .globl
+; WIN:        .p2align 2
+; WIN-LABEL:  __emutls_v.internal_y:
+; WIN-NEXT:   .long 8
+; WIN-NEXT:   .long 16
+; WIN-NEXT:   .long 0
+; WIN-NEXT:   .long __emutls_t.internal_y
+; WIN-LABEL:  __emutls_t.internal_y:
+; .quad 9 is equivalent to .long 9 .long 0
+; WIN-NEXT:   .quad 9
Index: lib/Target/ARM/ARMISelLowering.cpp
===================================================================
--- lib/Target/ARM/ARMISelLowering.cpp
+++ lib/Target/ARM/ARMISelLowering.cpp
@@ -2956,18 +2956,18 @@
 
 SDValue
 ARMTargetLowering::LowerGlobalTLSAddress(SDValue Op, SelectionDAG &DAG) const {
+  GlobalAddressSDNode *GA = cast<GlobalAddressSDNode>(Op);
+  if (DAG.getTarget().Options.EmulatedTLS)
+    return LowerToTLSEmulatedModel(GA, DAG);
+
   if (Subtarget->isTargetDarwin())
     return LowerGlobalTLSAddressDarwin(Op, DAG);
 
   if (Subtarget->isTargetWindows())
     return LowerGlobalTLSAddressWindows(Op, DAG);
 
   // TODO: implement the "local dynamic" model
   assert(Subtarget->isTargetELF() && "Only ELF implemented here");
-  GlobalAddressSDNode *GA = cast<GlobalAddressSDNode>(Op);
-  if (DAG.getTarget().Options.EmulatedTLS)
-    return LowerToTLSEmulatedModel(GA, DAG);
-
   TLSModel::Model model = getTargetMachine().getTLSModel(GA->getGlobal());
 
   switch (model) {


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40769.125275.patch
Type: text/x-patch
Size: 2941 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171202/be105210/attachment.bin>