[PATCH] D39348: Implement --just-symbols.

[Roland McGrath via llvm-commits]

For my particular use case, only the names and values matter.  But I think
it's just bad form to implement a feature for compatibility with GNU
linkers and then gratuitously fail to make it actually compatible just
because of laziness.

On Fri, Dec 1, 2017 at 6:02 PM, Rafael Avila de Espindola <
rafael.espindola at gmail.com> wrote:

> Rui Ueyama via Phabricator via llvm-commits
> <llvm-commits at lists.llvm.org> writes:
>
> > ruiu marked 5 inline comments as done.
> > ruiu added inline comments.
> >
> >
> > ================
> > Comment at: lld/ELF/InputFiles.cpp:1055
> > +template <class ELFT>
> > +std::vector<std::pair<StringRef, uint64_t>>
> > +elf::readSymbols(MemoryBufferRef MB) {
> > ----------------
> > mcgrathr wrote:
> >> The canonical semantics are to copy all the other fields as well, not
> just st_value.
> >> Only st_shndx is replaced with SHN_ABS.  The others are preserved
> (size, visibility, type, etc.).
> >>
> > Yeah that's true, but I wonder if real programs depend on it.
>
> Visibility might have an impact in what relaxations get applied, but
> that does sound fairly contrived.
>
> Roland, do you have a use case in mind for anything but the names?
>
> Cheers,
> Rafael
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171201/b67c5f97/attachment.html>