[PATCH] D40385: [mips][compiler-rt] Provide 64bit atomic add and sub

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 1 15:40:51 PST 2017


kcc added a comment.

This change introduces more ifdefs to this file, which is bad. 
It already has one ifdef -- and that one is already for "defined(_MIPS_SIM)"
Please don't introduce any more ifdefs, instead please add a new file (something_something_mips.h) and remove the only ifdef from here.


https://reviews.llvm.org/D40385





More information about the llvm-commits mailing list