[PATCH] D40697: Cache modulo values for the .gnu.hash section.

[Rafael Espíndola via llvm-commits]

>> OK, that makes it more likely that this is useful, but I still think
>> we should fully benchmark every single optimization.
>
>
> It depends. Your test cases do not cover all possible use cases, and since
> this is an optimization for that particular code path, it actually makes
> more sense to only measure the speed of that particular path. The benchmark
> numbers would be more noisy if you measure the entire execution time.

If the results don't show up in a full run then it is probably not
something that is worth optimizing for.

> It still make some sense to run some benchmarks just in case, because some
> seemingly unrelated change could results in a surprising performance
> degradation, but for that purpose, running one or two benchmarks should
> enough.

I still disagree. We had bad performance regressions from testing just
clang in the part and running all the benchmarks is pretty easy now
that the script is in lld.

In any case, the results look good, so LGTM.


Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Screen Shot 2017-12-01 at 3.27.14 PM.png
Type: image/png
Size: 408770 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171201/93ffd506/attachment-0001.png>