[PATCH] D40701: [ARM][DAG] Reenable post-legalize store merge

Evgeny Astigeevich via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 1 13:45:44 PST 2017


Hi Nirav,

I’ve just finished analysis of failures which had happened before this commit. Bisecting them I got r319036.

Thanks,
Evgeny

From: Nirav Davé <niravd at google.com>
Date: Friday, 1 December 2017 at 21:41
To: "reviews+D40701+public+80177a37c4360e77 at reviews.llvm.org" <reviews+D40701+public+80177a37c4360e77 at reviews.llvm.org>
Cc: Evgeny Astigeevich <Evgeny.Astigeevich at arm.com>, "Friedman, Eli" <efriedma at codeaurora.org>, "aemerson at apple.com" <aemerson at apple.com>, Javed Absar <Javed.Absar at arm.com>, Kristof Beyls <Kristof.Beyls at arm.com>, "hiraditya at msn.com" <hiraditya at msn.com>, llvm-commits <llvm-commits at lists.llvm.org>
Subject: Re: [PATCH] D40701: [ARM][DAG] Reenable post-legalize store merge

... and AArch64 was working correctly before this.

On Fri, Dec 1, 2017 at 4:40 PM, Nirav Davé <niravd at google.com<mailto:niravd at google.com>> wrote:
Let me back out the last commit. Presumably the constant store merge fix I made was wrong.

On Fri, Dec 1, 2017 at 4:33 PM, Evgeny Astigeevich via Phabricator <reviews at reviews.llvm.org<mailto:reviews at reviews.llvm.org>> wrote:
eastig added a comment.

Nirav,

There are stability and correctness issues on AArch64. The similar issues might exist on other ARM targets. Could you please disable MergeConsecutiveStores for all ARM targets including AArch64?

Thanks,
Evgeny


Repository:
  rL LLVM

https://reviews.llvm.org/D40701




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171201/8a31184b/attachment.html>


More information about the llvm-commits mailing list