[PATCH] D40741: [DWARFv5] Emit v5 line-table header

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/MC/MCDwarf.cpp:266
+  for (unsigned i = 0; i < MCDwarfDirs.size(); i++) {
+    MCOS->EmitBytes(MCDwarfDirs[i]);     // the DirectoryName
+    MCOS->EmitBytes(StringRef("\0", 1)); // the null term. of the string
----------------
For consistency with the comments below, perhaps turn this into a sentence?
`// The DirectoryName.`


================
Comment at: llvm/lib/MC/MCDwarf.cpp:297
+  MCOS->EmitBytes(StringRef("\0", 1));
+  for (unsigned i = 0; i < MCDwarfDirs.size(); ++i) {
+    MCOS->EmitBytes(MCDwarfDirs[i]);
----------------
`for (auto Dir : MCDwarfDirs)` ?


https://reviews.llvm.org/D40741