[PATCH] D40699: Split IndirectBr critical edges before PGO gen/use passes.

[David Li via Phabricator via llvm-commits]

davidxl added a comment.



1. As Eli pointed out, findIBRpredecessor may return null when there are multiple such predecessors, so perhaps create a new interface to return all such predecessors?

2. it is probably better to split out the refactoring part of the patch.



================
Comment at: lib/Passes/PassBuilder.cpp:515
+    // that's done during the pass.
+    MPM.addPass(SplitIndirectBrCriticalEdgesPass());
     MPM.addPass(PGOInstrumentationGen());
----------------
this is common to Use and Gen, so it is possible to move it into the previous SCC pipeline after InstCombinePass.


https://reviews.llvm.org/D40699