[PATCH] D39758: CodeGen: Fix pointer info in SplitVecOp_EXTRACT_VECTOR_ELT

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl added inline comments.


================
Comment at: lib/CodeGen/MachineInstr.cpp:1016
+    return PSVa->mayAlias(&MFI);
+  if (PSVb && MMOb->getPointerInfo().hasUnknownOffset())
+    return PSVb->mayAlias(&MFI);
----------------
efriedma wrote:
> The new patch is mostly the right idea, but I'm not sure I like the way hasUnknownOffset modifies the meaning of MachineMemOperand... we have code which accesses the offset scattered all over.
I think what I need is a PointerInfo which is the same as PointerInfo() but has a proper address space. i.e., it returns nulptr for getValue() and getPseudoValue() but returns correct address space. This way, most of the existing codes do not need change, and the backend can still get the correct addr space.

I will see if I can implement that.


https://reviews.llvm.org/D39758