[PATCH] D40369: Support sext, zext and trunc instructions in SCEV delinearization algorithm (new revision)

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 1 08:39:11 PST 2017


Meinersbur added a comment.

Thanks Alex for the patch. I just see it now. As Eli is mentioning already, could you separate the patch into separate differentials?

- One for renaming nominator/denominator to dividend/divisor. It will be discussed/decided on independently.
- One for allowing sext in delinerization (this differential, please add at least one unit-test)
- Another for zext, trunc expressions, these probably need some discussion about their correctness.

Thanks.


https://reviews.llvm.org/D40369





More information about the llvm-commits mailing list