[PATCH] D40732: [LLD][ELF] Add linker script generated data to non-contiguous relro test [NFC].

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 1 08:34:58 PST 2017


jhenderson added inline comments.


================
Comment at: test/ELF/relro-non-contiguous.s:27-28
+// RUN: .got.plt : { *(.got.plt) } \
+// RUN: .nonempty1  : { BYTE(1); *(.empty1) } \
+// RUN: .nonempty2 : { . = . + 3 ; *(.empty2) } \
+// RUN: .dynamic : { *(.dynamic) } \
----------------
I feel like these should be in two separate links. By combining the two, if one is correctly seen as influencing the size, but not the other, we won't notice.


https://reviews.llvm.org/D40732





More information about the llvm-commits mailing list