[PATCH] D40670: Let Alloca treated as nonnull for any alloca addr space value

Yaxun Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 1 08:28:57 PST 2017


yaxunl added a comment.

In https://reviews.llvm.org/D40670#941244, @nlopes wrote:

> This change is incorrect.  null can be a valid pointer in a non-0 address space, and alloca may return it.
>  If your target's address space guarantees that alloca doesn't return null, then we can probably make this target-dependent. But we cannot simply make it unconditional; that's not correct.


If whether alloca inst can be zero depending on target, then we need to make it target dependent. I will see if I can add this to TargetTransformInfo.


https://reviews.llvm.org/D40670





More information about the llvm-commits mailing list