[PATCH] D40632: Add flag to ArchiveWriter to test GNU64 format more efficiently

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: lib/Object/ArchiveWriter.cpp:490
     // member starts before the 4GB offset.
-    if (LastOffset >> 32 != 0)
+    if (LastOffset >= (1ULL << Sym64PowerOfTwo.getValue()))
       Kind = object::Archive::K_GNU64;
----------------
Do you need the `.getValue()` part? There should be an implicit conversion from the `cl::opt` to the value type (i.e. `int`).


Repository:
  rL LLVM

https://reviews.llvm.org/D40632