[PATCH] D40672: [lit] Don't enable LSan on darwin for clang 900

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 30 13:25:37 PST 2017


JDevlieghere created this revision.
Herald added a reviewer: modocache.

The latest clang that ships with Xcode (clang 900 or 9.0.0) does not support LSan. This fixes the lit configuration to reflect that.


Repository:
  rL LLVM

https://reviews.llvm.org/D40672

Files:
  utils/lit/lit/llvm/config.py


Index: utils/lit/lit/llvm/config.py
===================================================================
--- utils/lit/lit/llvm/config.py
+++ utils/lit/lit/llvm/config.py
@@ -223,12 +223,13 @@
             return True
 
         if re.match(r'^x86_64.*-apple', triple):
-            version_number = int(
-                re.search(r'version ([0-9]+)\.', version_string).group(1))
+            version_regex = re.search(r'version ([0-9]+)\.([0-9]+).([0-9]+)', version_string)
+            major_version_number = int(version_regex.group(1))
+            minor_version_number = int(version_regex.group(3))
             if 'Apple LLVM' in version_string:
-                return version_number >= 9
+                return major_version_number >= 9 and minor_version_number > 0
             else:
-                return version_number >= 5
+                return major_version_number >= 5
 
         return False
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D40672.124997.patch
Type: text/x-patch
Size: 913 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171130/167e015d/attachment.bin>


More information about the llvm-commits mailing list